Backport of [NET-4958] Fix issue where envoy endpoints would fail to populate after snapshot restore into release/1.16.x #18645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-4958/missing-endpoints/totally-amazed-elephant
branch
from
f03c007
to
8656d4e
Compare
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-4958/missing-endpoints/totally-amazed-elephant
branch
from
39f3b02
to
e792bf4
Compare
github-team-consul-core-pr-approver
approved these changes
Sep 1, 2023
hc-github-team-consul-core
deleted the
backport/derekm/NET-4958/missing-endpoints/totally-amazed-elephant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18636 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Fixes an issue that was introduced in #17775. This issue happens because a long-lived pointer to the state store is held, which is unsafe to do. Snapshot restorations will swap out this state store, meaning that the server's proxycfg endpoint-health watches would break.
Any mesh services utilizing a consul-dataplane workflow would experience this problem, which is primarily consul-k8s deployments. This issue will typically result in Envoy proxies displaying zero upstream endpoints to contact.
Overview of commits